-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Merged by Bors] - feat: subscript and superscript delaborators #23018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
4e002c9
feat: delabSubscript and delabSuperscript
gio256 66eb431
fix: private function application
gio256 f5a8774
test: restructure sub/superscript delab tests
gio256 d561fd0
fix: subscript partially-applied functions
gio256 b5ae8b9
test: better syntax for subscript test macro
gio256 a019c11
fix: prefer getExpr to passing around expression
gio256 315b848
fix: () : Unit is valid in subscripts
gio256 708ce39
fix: camelCase defs
gio256 36e3612
test: test partially-applied fn in subscript
gio256 04edce2
chore: make sub/superscriptable fns private
gio256 2355936
doc: clean up and comment
gio256 3fdd2b1
chore: clarify name function
gio256 00a22e5
doc: clarify comment
gio256 abc6974
chore: imports, comments, add delab section
gio256 9b548f3
test: add tests that don't trigger the delaborator
gio256 2e571a2
fix: delab first, then check subscript validity
gio256 a870c10
chore: clean up isSuperscriptable
gio256 ad05d28
chore: combine superscriptable and subscriptable
gio256 adc446e
test: rm smul test
gio256 5a5abad
doc: add comment for Superscript.isValid
gio256 1dfdd75
test: clean up test fn naming
gio256 eab471f
test: add nested superscript(subscript) tests
gio256 ec0c3ad
doc: fix typo
gio256 4b97140
test: add dot notation tests
gio256 272b535
chore: rm unused universe
gio256 fbf9915
style: use anon dot notation in delabSubscript fns
gio256 df5fd0c
fix: reject values that are already subscripted
gio256 c93827e
Merge branch 'master' into gio/subscript
gio256 8bb34e3
chore: clarify Superscript.isValid logic
gio256 e78cd37
style: golf Superscript.isValid valid helper fn
gio256 2f65a68
style: golf Superscript.isValid scripted helper fn
gio256 26e7384
restore using decl_name to guarantee SyntaxNodeKind uniqueness
kmill fb95ea2
minimize diff
kmill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.