Skip to content

feat(Geometry/Euclidean/SignedDist): signedDist between two points#24245

Closed
JovanGerb wants to merge 7 commits intomasterfrom
signedDist
Closed

feat(Geometry/Euclidean/SignedDist): signedDist between two points#24245
JovanGerb wants to merge 7 commits intomasterfrom
signedDist

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb commented Apr 21, 2025

This PR defines signedDist, the signed distance between two points.

It redefines signedInfDist so that it uses signedDist.

The motivation is to use this in IMO2020Q6. Additionally this definition will be useful for properly reasoning about the power of a point

#mathlib4 > Signed distance between points

some comments:

  • should signedDistLinear be private?
  • should signedDist and signedInfDist be made continuous bunled maps in this PR?
  • I'm not too happy about the hypothesis in signedDist_congr (h : ∃ r > (0 : ℝ), r • v = w). This relationship between v and w is a symmetric one that should have some API around it, similar to SameRay. It could also be spelled as (ℝ≥0 ∙ v) = ℝ≥0 ∙ w

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 21, 2025

PR summary c35fbb5256

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ abs_signedDist_eq_dist_iff_vsub_mem_span
+ abs_signedDist_le_dist
+ signedDist
+ signedDist_anticomm
+ signedDist_apply
+ signedDist_apply_apply
+ signedDist_apply_linear
+ signedDist_apply_linear_apply
+ signedDist_congr
+ signedDist_eq_dist_iff_vsub_mem_span
+ signedDist_eq_zero_of_orthogonal
+ signedDist_le_dist
+ signedDist_left_congr
+ signedDist_linear_apply
+ signedDist_linear_apply_apply
+ signedDist_neg
+ signedDist_right_congr
+ signedDist_self
+ signedDist_smul
+ signedDist_triangle
+ signedDist_triangle_left
+ signedDist_triangle_right
+ signedDist_vadd_left
+ signedDist_vadd_left_swap
+ signedDist_vadd_right
+ signedDist_vadd_right_swap
+ signedDist_vadd_vadd
+ signedDist_vsub_self
+ signedDist_vsub_self_rev
+ signedDist_zero
+ signedInfDist_def
+ signedInfDist_eq_signedDist
+ signedInfDist_eq_signedDist_orthogonalProjection
+ signedInfDist_singleton
- signedInfDist_apply
- signedInfDist_linear
- signedInfDist_linear_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg added the t-euclidean-geometry Affine and axiomatic geometry label May 2, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 21, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@JovanGerb
Copy link
Copy Markdown
Contributor Author

This has moved to #27260

@JovanGerb JovanGerb closed this Jul 18, 2025
@YaelDillies YaelDillies deleted the signedDist branch August 17, 2025 11:45
mathlib-bors bot pushed a commit that referenced this pull request Sep 1, 2025
…27260)

original PR: #24245

This PR defines `signedDist`, the signed distance between two points.

It also redefines `signedInfDist` so that it uses `signedDist`.

The motivation is to use this in IMO2020Q6. Additionally this definition will be useful for properly reasoning about the power of a point

[#mathlib4 > Signed distance between points](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Signed.20distance.20between.20points)

some comments:

* should `signedDistLinear` be `private`?
* I'm not too happy about the hypothesis in `signedDist_congr (h : ∃ r > (0 : ℝ), r • v = w)`. This relationship between `v` and `w` is a symmetric one that should have some API around it, similar to `SameRay`. It could also be spelled as `(ℝ≥0 ∙ v) = ℝ≥0 ∙ w`
CBirkbeck pushed a commit to CBirkbeck/mathlib4 that referenced this pull request Sep 8, 2025
…eanprover-community#27260)

original PR: leanprover-community#24245

This PR defines `signedDist`, the signed distance between two points.

It also redefines `signedInfDist` so that it uses `signedDist`.

The motivation is to use this in IMO2020Q6. Additionally this definition will be useful for properly reasoning about the power of a point

[#mathlib4 > Signed distance between points](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Signed.20distance.20between.20points)

some comments:

* should `signedDistLinear` be `private`?
* I'm not too happy about the hypothesis in `signedDist_congr (h : ∃ r > (0 : ℝ), r • v = w)`. This relationship between `v` and `w` is a symmetric one that should have some API around it, similar to `SameRay`. It could also be spelled as `(ℝ≥0 ∙ v) = ℝ≥0 ∙ w`
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request Sep 10, 2025
…eanprover-community#27260)

original PR: leanprover-community#24245

This PR defines `signedDist`, the signed distance between two points.

It also redefines `signedInfDist` so that it uses `signedDist`.

The motivation is to use this in IMO2020Q6. Additionally this definition will be useful for properly reasoning about the power of a point

[#mathlib4 > Signed distance between points](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Signed.20distance.20between.20points)

some comments:

* should `signedDistLinear` be `private`?
* I'm not too happy about the hypothesis in `signedDist_congr (h : ∃ r > (0 : ℝ), r • v = w)`. This relationship between `v` and `w` is a symmetric one that should have some API around it, similar to `SameRay`. It could also be spelled as `(ℝ≥0 ∙ v) = ℝ≥0 ∙ w`
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
…eanprover-community#27260)

original PR: leanprover-community#24245

This PR defines `signedDist`, the signed distance between two points.

It also redefines `signedInfDist` so that it uses `signedDist`.

The motivation is to use this in IMO2020Q6. Additionally this definition will be useful for properly reasoning about the power of a point

[#mathlib4 > Signed distance between points](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Signed.20distance.20between.20points)

some comments:

* should `signedDistLinear` be `private`?
* I'm not too happy about the hypothesis in `signedDist_congr (h : ∃ r > (0 : ℝ), r • v = w)`. This relationship between `v` and `w` is a symmetric one that should have some API around it, similar to `SameRay`. It could also be spelled as `(ℝ≥0 ∙ v) = ℝ≥0 ∙ w`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) t-euclidean-geometry Affine and axiomatic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants