Skip to content

[Merged by Bors] - feat(Geometry/Euclidean/SignedDist): signedDist between two points#27260

Closed
JovanGerb wants to merge 19 commits intoleanprover-community:masterfrom
JovanGerb:signedDist
Closed

[Merged by Bors] - feat(Geometry/Euclidean/SignedDist): signedDist between two points#27260
JovanGerb wants to merge 19 commits intoleanprover-community:masterfrom
JovanGerb:signedDist

Conversation

@JovanGerb
Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb commented Jul 18, 2025

original PR: #24245

This PR defines signedDist, the signed distance between two points.

It also redefines signedInfDist so that it uses signedDist.

The motivation is to use this in IMO2020Q6. Additionally this definition will be useful for properly reasoning about the power of a point

#mathlib4 > Signed distance between points

some comments:

  • should signedDistLinear be private?
  • I'm not too happy about the hypothesis in signedDist_congr (h : ∃ r > (0 : ℝ), r • v = w). This relationship between v and w is a symmetric one that should have some API around it, similar to SameRay. It could also be spelled as (ℝ≥0 ∙ v) = ℝ≥0 ∙ w

@JovanGerb JovanGerb changed the title Signed dist feat(Geometry/Euclidean/SignedDist): signedDist between two points Jul 18, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 18, 2025

PR summary c2c4e1f99f

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Geometry.Euclidean.SignedDist 2042 2040 -2 (-0.10%)
Import changes for all files
Files Import difference
Mathlib.Geometry.Euclidean.Incenter Mathlib.Geometry.Euclidean.SignedDist -2

Declarations diff

+ abs_signedDist_eq_dist_iff_vsub_mem_span
+ abs_signedDist_le_dist
+ signedDist
+ signedDist_anticomm
+ signedDist_apply
+ signedDist_apply_apply
+ signedDist_apply_linear
+ signedDist_apply_linear_apply
+ signedDist_congr
+ signedDist_eq_dist_iff_vsub_mem_span
+ signedDist_eq_zero_of_orthogonal
+ signedDist_le_dist
+ signedDist_left_congr
+ signedDist_linear_apply
+ signedDist_linear_apply_apply
+ signedDist_neg
+ signedDist_right_congr
+ signedDist_self
+ signedDist_smul
+ signedDist_triangle
+ signedDist_triangle_left
+ signedDist_triangle_right
+ signedDist_vadd_left
+ signedDist_vadd_left_swap
+ signedDist_vadd_right
+ signedDist_vadd_right_swap
+ signedDist_vadd_vadd
+ signedDist_vsub_self
+ signedDist_vsub_self_rev
+ signedDist_zero
+ signedInfDist_def
+ signedInfDist_eq_signedDist_of_mem
+ signedInfDist_eq_signedDist_orthogonalProjection
+ signedInfDist_singleton
- signedInfDist_apply
- signedInfDist_linear
- signedInfDist_linear_apply

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 18, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot removed the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 19, 2025
@mathlib4-dependent-issues-bot
Copy link
Copy Markdown
Collaborator

This PR/issue depends on:

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 19, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 19, 2025
@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 23, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Aug 16, 2025
@jsm28
Copy link
Copy Markdown
Contributor

jsm28 commented Aug 30, 2025

maintainer merge

@github-actions
Copy link
Copy Markdown

🚀 Pull request has been placed on the maintainer queue by jsm28.

@ghost ghost added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Aug 30, 2025
Copy link
Copy Markdown
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels Sep 1, 2025
mathlib-bors bot pushed a commit that referenced this pull request Sep 1, 2025
…27260)

original PR: #24245

This PR defines `signedDist`, the signed distance between two points.

It also redefines `signedInfDist` so that it uses `signedDist`.

The motivation is to use this in IMO2020Q6. Additionally this definition will be useful for properly reasoning about the power of a point

[#mathlib4 > Signed distance between points](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Signed.20distance.20between.20points)

some comments:

* should `signedDistLinear` be `private`?
* I'm not too happy about the hypothesis in `signedDist_congr (h : ∃ r > (0 : ℝ), r • v = w)`. This relationship between `v` and `w` is a symmetric one that should have some API around it, similar to `SameRay`. It could also be spelled as `(ℝ≥0 ∙ v) = ℝ≥0 ∙ w`
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Sep 1, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Geometry/Euclidean/SignedDist): signedDist between two points [Merged by Bors] - feat(Geometry/Euclidean/SignedDist): signedDist between two points Sep 1, 2025
@mathlib-bors mathlib-bors bot closed this Sep 1, 2025
CBirkbeck pushed a commit to CBirkbeck/mathlib4 that referenced this pull request Sep 8, 2025
…eanprover-community#27260)

original PR: leanprover-community#24245

This PR defines `signedDist`, the signed distance between two points.

It also redefines `signedInfDist` so that it uses `signedDist`.

The motivation is to use this in IMO2020Q6. Additionally this definition will be useful for properly reasoning about the power of a point

[#mathlib4 > Signed distance between points](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Signed.20distance.20between.20points)

some comments:

* should `signedDistLinear` be `private`?
* I'm not too happy about the hypothesis in `signedDist_congr (h : ∃ r > (0 : ℝ), r • v = w)`. This relationship between `v` and `w` is a symmetric one that should have some API around it, similar to `SameRay`. It could also be spelled as `(ℝ≥0 ∙ v) = ℝ≥0 ∙ w`
yuanyi-350 pushed a commit to yuanyi-350/yuanyi_mathlib4 that referenced this pull request Sep 10, 2025
…eanprover-community#27260)

original PR: leanprover-community#24245

This PR defines `signedDist`, the signed distance between two points.

It also redefines `signedInfDist` so that it uses `signedDist`.

The motivation is to use this in IMO2020Q6. Additionally this definition will be useful for properly reasoning about the power of a point

[#mathlib4 > Signed distance between points](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Signed.20distance.20between.20points)

some comments:

* should `signedDistLinear` be `private`?
* I'm not too happy about the hypothesis in `signedDist_congr (h : ∃ r > (0 : ℝ), r • v = w)`. This relationship between `v` and `w` is a symmetric one that should have some API around it, similar to `SameRay`. It could also be spelled as `(ℝ≥0 ∙ v) = ℝ≥0 ∙ w`
joelriou pushed a commit to joelriou/mathlib4 that referenced this pull request Oct 2, 2025
…eanprover-community#27260)

original PR: leanprover-community#24245

This PR defines `signedDist`, the signed distance between two points.

It also redefines `signedInfDist` so that it uses `signedDist`.

The motivation is to use this in IMO2020Q6. Additionally this definition will be useful for properly reasoning about the power of a point

[#mathlib4 > Signed distance between points](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Signed.20distance.20between.20points)

some comments:

* should `signedDistLinear` be `private`?
* I'm not too happy about the hypothesis in `signedDist_congr (h : ∃ r > (0 : ℝ), r • v = w)`. This relationship between `v` and `w` is a symmetric one that should have some API around it, similar to `SameRay`. It could also be spelled as `(ℝ≥0 ∙ v) = ℝ≥0 ∙ w`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-euclidean-geometry Affine and axiomatic geometry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants