Skip to content

[Merged by Bors] - chore: remove some adaptation notes#24492

Closed
Parcly-Taxel wants to merge 8 commits intomasterfrom
some_adaptations
Closed

[Merged by Bors] - chore: remove some adaptation notes#24492
Parcly-Taxel wants to merge 8 commits intomasterfrom
some_adaptations

Conversation

@Parcly-Taxel
Copy link
Copy Markdown
Collaborator

@Parcly-Taxel Parcly-Taxel commented May 1, 2025 •
edited by mathlib-bors bot
Loading

No description provided.

@Parcly-Taxel Parcly-Taxel added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label May 1, 2025
@Parcly-Taxel Parcly-Taxel requested a review from kim-em May 1, 2025 03:10
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 1, 2025 •
edited
Loading

PR summary 04a76d4aa0

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Decrease in tech debt: (relative, absolute) = (4.00, 0.03)
Current number Change Type
120 -4 adaptation notes

Current commit 04a76d4aa0
Reference commit 42755fb41c

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

grunweg
grunweg reviewed May 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a look: half the changes are immediately good, for the others I have a few questions. Perhaps you can convince me that they're also useful.

Mathlib/Algebra/Homology/Single.lean Outdated
The following is horrible. -/
convert (id_zero (C := V)).symm
all_goals simp [if_neg h]
· change OfNat.ofNat 0 = _; dsimp only [id_eq]; rw [if_neg h, id_zero]
Copy link
Copy Markdown
Contributor

@grunweg grunweg May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure about the change; otherwise, I like this one.

Copy link
Copy Markdown
Collaborator Author

@Parcly-Taxel Parcly-Taxel May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the best thing I could find.

Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue here is that dsimp does not simplify number literals, otherwise this could be done much more nicely.

Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a thread about it #lean4 > dsimp doesn't visit numerals

Copy link
Copy Markdown
Contributor

@grunweg grunweg May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And three weeks later, nothing happened on zulip. I don't think we should paper over that core issue; at the very least, there should be a comment about the core issue (and perhaps a Lean issue filed).

Copy link
Copy Markdown
Contributor

@JovanGerb JovanGerb May 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm attempting a fix at leanprover/lean4#8433

Copy link
Copy Markdown
Contributor

@grunweg grunweg May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's land this PR now, and clean this up when the Lean change lands in mathlib.

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label May 1, 2025
@Parcly-Taxel Parcly-Taxel removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 1, 2025
@leanprover-community-bot-assistant
Copy link
Copy Markdown
Collaborator

leanprover-community-bot-assistant commented May 6, 2025

This pull request has conflicts, please merge master and resolve them.

@leanprover-community-bot-assistant leanprover-community-bot-assistant added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 6, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 7, 2025
grunweg
grunweg reviewed May 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took another look. For two items, I'd like a second opinion. @jcommelin perhaps?

Mathlib/Algebra/Homology/Single.lean Outdated
The following is horrible. -/
convert (id_zero (C := V)).symm
all_goals simp [if_neg h]
· change OfNat.ofNat 0 = _; dsimp only [id_eq]; rw [if_neg h, id_zero]
Copy link
Copy Markdown
Contributor

@grunweg grunweg May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And three weeks later, nothing happened on zulip. I don't think we should paper over that core issue; at the very least, there should be a comment about the core issue (and perhaps a Lean issue filed).

@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label May 20, 2025
@Parcly-Taxel Parcly-Taxel removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 20, 2025
@Parcly-Taxel Parcly-Taxel requested a review from grunweg May 20, 2025 13:55
@JovanGerb JovanGerb mentioned this pull request May 21, 2025
Open
@grunweg
Copy link
Copy Markdown
Contributor

grunweg commented May 23, 2025

maintainer merge

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 23, 2025

🚀 Pull request has been placed on the maintainer queue by grunweg.

@github-actions github-actions bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 23, 2025
Vierkantor
Vierkantor approved these changes May 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@ghost ghost added ready-to-merge This PR has been sent to bors. and removed maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. labels May 23, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 23, 2025
@Parcly-Taxel
chore: remove some adaptation notes (#24492)
9368322
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 23, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove some adaptation notes [Merged by Bors] - chore: remove some adaptation notes May 23, 2025
@mathlib-bors mathlib-bors bot closed this May 23, 2025
@mathlib-bors mathlib-bors bot deleted the some_adaptations branch May 23, 2025 10:37
bwehlin pushed a commit to bwehlin/mathlib4 that referenced this pull request May 31, 2025
@Parcly-Taxel
chore: remove some adaptation notes (leanprover-community#24492)
eec51de
joelriou pushed a commit that referenced this pull request Jun 8, 2025
@Parcly-Taxel @joelriou
chore: remove some adaptation notes (#24492)
4694e4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JovanGerb JovanGerb JovanGerb left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

@kim-em kim-em Awaiting requested review from kim-em

@grunweg grunweg Awaiting requested review from grunweg

Assignees

No one assigned

Labels

ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Parcly-Taxel @leanprover-community-bot-assistant @grunweg @Vierkantor @JovanGerb