feat: let simp simplify numerals#8433
Open
JovanGerb wants to merge 11 commits intoleanprover:masterfrom
Open
Conversation
Contributor
|
(Would you like to add a test, at some point? I know this PR is still a draft.) |
JovanGerb
changed the title
simp and dsimp simplify numeralssimp simplify numerals
github-actions
bot
added
the
toolchain-available
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 22, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 22, 2025
ghost
added
the
breaks-mathlib
|
Mathlib CI status (docs):
|
ghost
added
builds-mathlib
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 23, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 23, 2025
ghost
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
May 24, 2025
ghost
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 24, 2025
Contributor
Author
|
I've added a test now, which is a minimization of the example in Mathlib. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lets
simpsimplify the type and instance of number literals.This came up here: leanprover-community/mathlib4#24492 (comment)