Skip to content

[Merged by Bors] - feat(CI): add emoji to maintainer merge'd PRs also#24544

Closed
grunweg wants to merge 3 commits intomasterfrom
MR-mm-emoji
Closed

[Merged by Bors] - feat(CI): add emoji to maintainer merge'd PRs also#24544
grunweg wants to merge 3 commits intomasterfrom
MR-mm-emoji

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented May 2, 2025

The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.


This PR is cargo-culted, please review carefully.

Open in Gitpod

The zulip bot reacts to all label changes, including arbitrary users setting
that label. That seems harmless: the emoji is only informational, and the
effect of false marking a PR with the label may simply be that it doesn't
reviewed as well.
@grunweg grunweg added the CI Modifies the continuous integration setup or other automation label May 2, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 2, 2025

PR summary e2a5289bd7

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Copy Markdown
Contributor

@adomani adomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Just one question: hammer is an "official" name for the emoji? If the emoji is a custom emoji, then I think that we should also track down some internal ID number, like for the closed PR emoji.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented May 2, 2025

Yes, 🔨 is an official emoji. See e.g here or try the signal messenger.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented May 2, 2025

I just pushed another commit, merging the two essentially duplicate workflows into one.

@adomani
Copy link
Copy Markdown
Contributor

adomani commented May 2, 2025

Thanks, I like the newer version, let's try it out!

bors merge

@ghost ghost added the ready-to-merge This PR has been sent to bors. label May 2, 2025
mathlib-bors bot pushed a commit that referenced this pull request May 2, 2025
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented May 2, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CI): add emoji to maintainer merge'd PRs also [Merged by Bors] - feat(CI): add emoji to maintainer merge'd PRs also May 2, 2025
@mathlib-bors mathlib-bors bot closed this May 2, 2025
@mathlib-bors mathlib-bors bot deleted the MR-mm-emoji branch May 2, 2025 11:54
@adomani adomani added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label May 2, 2025
pfaffelh pushed a commit that referenced this pull request May 2, 2025
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
riccardobrasca pushed a commit that referenced this pull request May 7, 2025
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
tannerduve pushed a commit that referenced this pull request May 13, 2025
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Modifies the continuous integration setup or other automation maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants