[Merged by Bors] - feat(CI): add emoji to maintainer merge'd PRs also#24544
Closed
[Merged by Bors] - feat(CI): add emoji to maintainer merge'd PRs also#24544
Conversation
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
PR summary e2a5289bd7Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Closed
1 task
adomani
reviewed
May 2, 2025
Contributor
adomani
left a comment
There was a problem hiding this comment.
This looks good to me!
Just one question: hammer is an "official" name for the emoji? If the emoji is a custom emoji, then I think that we should also track down some internal ID number, like for the closed PR emoji.
Contributor
Author
|
Yes, 🔨 is an official emoji. See e.g here or try the signal messenger. |
Contributor
Author
|
I just pushed another commit, merging the two essentially duplicate workflows into one. |
Contributor
|
Thanks, I like the newer version, let's try it out! bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
May 2, 2025
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
Contributor
|
Pull request successfully merged into master. Build succeeded: |
pfaffelh
pushed a commit
that referenced
this pull request
May 2, 2025
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
riccardobrasca
pushed a commit
that referenced
this pull request
May 7, 2025
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
tannerduve
pushed a commit
that referenced
this pull request
May 13, 2025
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
This PR is cargo-culted, please review carefully.