Add basic support for nRF54lv10#609
Conversation
e87e449 to
668fb71
Compare
89f4f76 to
a16516b
Compare
|
You can find the documentation preview for this PR here. |
86c4102 to
109f116
Compare
7319aa4 to
b4349d0
Compare
anhmolt
left a comment
There was a problem hiding this comment.
Looks mostly good.
RAM sizes looks good, though I'm unsure if including the extra 320 bytes of the last KiB of RAM warrants the extra "magic"/'320' number here and there. And the fact that it is only included in the application RAM when not using the MCUboot variants adds some complexity between.
If the size of the region for DFU retained settings is reworked and there is no restriction that it needs to be larger than 1kB or similar, then maybe these 320 could be reserved for retention usage. Similar for other boards, if we want to respect the memory range reserved for VPR saved context, then maybe 1kB can be removed at the end, the VPR saved context area can be left untouched and the rest goes to retention?
Just some thoughts.
ac6da42 to
0d4ef81
Compare
I agree with Andreas, I think we should just ignore the last 320 bytes from the setup of application RAM. |
0d4ef81 to
9d05da0
Compare
9d05da0 to
49fa50c
Compare
49fa50c to
623309e
Compare
Yes, but perhaps not only for that. I think it would be really good if we had a page in the doc with the memory layout for all SoC. |
e773af1 to
f9b2dac
Compare
| help | ||
| SoftDevice variant used to select the SoftDevice API include path under | ||
| `components/softdevice/<soctarget>/<softdevice>/<softdevice>_API/include` |
There was a problem hiding this comment.
| help | |
| SoftDevice variant used to select the SoftDevice API include path under | |
| `components/softdevice/<soctarget>/<softdevice>/<softdevice>_API/include` | |
| help | |
| SoftDevice variant used to select the SoftDevice API include path under | |
| `components/softdevice/<soctarget>/<softdevice>/<softdevice>_API/include` |
Help text should be indented with two spaces instead of tab for consistency. This is a bit of an oddball but let's align.
| help | ||
| SoC series variant used to select the SoftDevice API include path under | ||
| `components/softdevice/<soctarget>/<softdevice>/<softdevice>_API/include` |
There was a problem hiding this comment.
| help | |
| SoC series variant used to select the SoftDevice API include path under | |
| `components/softdevice/<soctarget>/<softdevice>/<softdevice>_API/include` | |
| help | |
| SoC series variant used to select the SoftDevice API include path under | |
| `components/softdevice/<soctarget>/<softdevice>/<softdevice>_API/include` |
f9b2dac to
dff0c45
Compare
There was a problem hiding this comment.
@nordicjm static check on dts files is green.
@bjorn-tore-taraldsen please address linting issues as per patch attached to comply with zephyr style guide
linting.patch
nordicjm
left a comment
There was a problem hiding this comment.
Changes OK once dts changes are applied
Add support for new device nRF54LV10A in the bm_nrf54lv10dk board. Signed-off-by: Bjørn Tore Taraldsen <bjorn.tore.taraldsen@nordicsemi.no> Signed-off-by: Bartosz Gentkowski <bartosz.gentkowski@nordicsemi.no>
dff0c45 to
0963043
Compare
Add basic support for new device nRF54LV10 including new board targets and NUS and HRS sample.