feat: preserve original point cloud fields and add optional downsampling for initial_map visualization#84
Open
gakutasu wants to merge 2 commits intorsasaki0109:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initial_mapwas previously published asPointXYZI, discarding alloriginal fields (e.g. RGB) from the source PCD/PLY file. It now uses
raw_map_cloud(PCLPointCloud2) directly, preserving all fields.viz_downsample(bool, default:false): enable voxel downsamplingfor the published
initial_mapviz_voxel_leaf_size(double, default:0.5): leaf size used whenviz_downsampleistrueMotivation
Maps with RGB fields (e.g. colorized LiDAR or photogrammetry-derived PCD)
were not renderable in color in RViz2 because the conversion to
PointXYZIstripped the color data. Additionally, large maps caused RViz2 performance
issues due to publishing at full resolution.